Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LETKF suite and initial tasks. #232

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Add LETKF suite and initial tasks. #232

merged 5 commits into from
Sep 19, 2023

Conversation

CEgerer93
Copy link
Contributor

@CEgerer93 CEgerer93 commented Sep 18, 2023 •
edited
Loading

Description

Begins support for LETKF and other ensemble-based DA methods, more generally, in geos_atmosphere. Note - in the current form, this PR lacks complete support for a LocalEnsembleDA task.

Dependencies

  • waiting on completed yaml templating
  • Cylc workflow for LETKF

Impact

None.

danholdaway
danholdaway approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@danholdaway danholdaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding this new suite. Just one minor comment.

src/swell/tasks/task_questions.yaml Outdated Show resolved Hide resolved
@danholdaway danholdaway changed the title Feature/letkf atm Add LETKF suite and initial tasks. Sep 18, 2023
@danholdaway danholdaway merged commit 1ef2797 into develop Sep 19, 2023
@danholdaway danholdaway deleted the feature/letkf-atm branch September 19, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danholdaway danholdaway danholdaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CEgerer93 @danholdaway